aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAvatar Ciaran McCreesh <ciaran.mccreesh@googlemail.com> 2006-02-23 13:51:03 +0000
committerAvatar Ciaran McCreesh <ciaran.mccreesh@googlemail.com> 2006-02-23 13:51:03 +0000
commitee78d61d0d31fa0f3e343c1f6806b64c5905a9c0 (patch)
tree864ea0de332de1a4a650ccdd8f2dd48a6e0b4fe2
parent8ef1ae2575051a1f56b7ed1f07b7f3e7ffeed43f (diff)
downloadpaludis-ee78d61d0d31fa0f3e343c1f6806b64c5905a9c0.tar.gz
paludis-ee78d61d0d31fa0f3e343c1f6806b64c5905a9c0.tar.xz
Check for deprecated things in inherits
-rw-r--r--paludis/qa/files.m41
-rw-r--r--paludis/qa/inherits_check.cc88
-rw-r--r--paludis/qa/inherits_check.hh51
3 files changed, 140 insertions, 0 deletions
diff --git a/paludis/qa/files.m4 b/paludis/qa/files.m4
index 88f046c..b5eb297 100644
--- a/paludis/qa/files.m4
+++ b/paludis/qa/files.m4
@@ -31,6 +31,7 @@ add(`glep_31_check', `hh', `cc', `test')
add(`has_ebuilds_check', `hh', `cc', `test', `testscript')
add(`has_misc_files_check', `hh', `cc', `test', `testscript')
add(`homepage_check', `hh', `cc')
+add(`inherits_check', `hh', `cc')
add(`iuse_check', `hh', `cc')
add(`keywords_check', `hh', `cc')
add(`license_check', `hh', `cc')
diff --git a/paludis/qa/inherits_check.cc b/paludis/qa/inherits_check.cc
new file mode 100644
index 0000000..98502d6
--- /dev/null
+++ b/paludis/qa/inherits_check.cc
@@ -0,0 +1,88 @@
+/* vim: set sw=4 sts=4 et foldmethod=syntax : */
+
+/*
+ * Copyright (c) 2006 Ciaran McCreesh <ciaranm@gentoo.org>
+ *
+ * This file is part of the Paludis package manager. Paludis is free software;
+ * you can redistribute it and/or modify it under the terms of the GNU General
+ * Public License version 2, as published by the Free Software Foundation.
+ *
+ * Paludis is distributed in the hope that it will be useful, but WITHOUT ANY
+ * WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+ * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
+ * details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc., 59 Temple
+ * Place, Suite 330, Boston, MA 02111-1307 USA
+ */
+
+#include "inherits_check.hh"
+#include <paludis/tokeniser.hh>
+#include <paludis/join.hh>
+#include <set>
+#include <algorithm>
+#include <iterator>
+
+using namespace paludis;
+using namespace paludis::qa;
+
+InheritsCheck::InheritsCheck()
+{
+}
+
+CheckResult
+InheritsCheck::operator() (const EbuildCheckData & e) const
+{
+ CheckResult result(stringify(e.get<ecd_name>()) + "-" + stringify(e.get<ecd_version>()),
+ identifier());
+
+ try
+ {
+ PackageDatabaseEntry ee(e.get<ecd_name>(), e.get<ecd_version>(),
+ e.get<ecd_environment>()->package_database()->favourite_repository());
+ VersionMetadata::ConstPointer metadata(
+ e.get<ecd_environment>()->package_database()->fetch_metadata(ee));
+
+ std::set<std::string> inherits;
+ Tokeniser<delim_kind::AnyOfTag, delim_mode::DelimiterTag> tokeniser(" \t\n");
+ tokeniser.tokenise(metadata->get(vmk_inherited), std::inserter(inherits, inherits.begin()));
+
+ static std::set<std::string> inherits_blacklist;
+ if (inherits_blacklist.empty())
+ {
+ inherits_blacklist.insert("kmod");
+ inherits_blacklist.insert("kernel-mod");
+ inherits_blacklist.insert("gtk-engines");
+ inherits_blacklist.insert("gtk-engines2");
+ }
+
+ static std::set<std::string> bad_inherits;
+ std::set_intersection(inherits.begin(), inherits.end(),
+ inherits_blacklist.begin(), inherits_blacklist.end(),
+ std::inserter(bad_inherits, bad_inherits.begin()));
+
+ if (! inherits_blacklist.empty())
+ result << Message(qal_major, "Deprecated inherits '" + join(bad_inherits.begin(),
+ bad_inherits.end(), "', '") + "'");
+ }
+ catch (const InternalError &)
+ {
+ throw;
+ }
+ catch (const Exception & e)
+ {
+ result << Message(qal_fatal, "Caught Exception '" + e.message() + "' ("
+ + e.what() + ")");
+ }
+
+ return result;
+}
+
+const std::string &
+InheritsCheck::identifier()
+{
+ static const std::string id("inherits");
+ return id;
+}
+
diff --git a/paludis/qa/inherits_check.hh b/paludis/qa/inherits_check.hh
new file mode 100644
index 0000000..aa3e084
--- /dev/null
+++ b/paludis/qa/inherits_check.hh
@@ -0,0 +1,51 @@
+/* vim: set sw=4 sts=4 et foldmethod=syntax : */
+
+/*
+ * Copyright (c) 2006 Ciaran McCreesh <ciaranm@gentoo.org>
+ *
+ * This file is part of the Paludis package manager. Paludis is free software;
+ * you can redistribute it and/or modify it under the terms of the GNU General
+ * Public License version 2, as published by the Free Software Foundation.
+ *
+ * Paludis is distributed in the hope that it will be useful, but WITHOUT ANY
+ * WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+ * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
+ * details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc., 59 Temple
+ * Place, Suite 330, Boston, MA 02111-1307 USA
+ */
+
+#ifndef PALUDIS_GUARD_PALUDIS_QA_INHERITS_CHECK_HH
+#define PALUDIS_GUARD_PALUDIS_QA_INHERITS_CHECK_HH 1
+
+#include <paludis/qa/ebuild_check.hh>
+#include <string>
+
+namespace paludis
+{
+ namespace qa
+ {
+ class InheritsCheck :
+ public EbuildCheck
+ {
+ public:
+ InheritsCheck();
+
+ CheckResult operator() (const EbuildCheckData &) const;
+
+ static const std::string & identifier();
+
+ virtual std::string describe() const
+ {
+ return "Checks that inherits are sane";
+ }
+ };
+
+ static const EbuildCheckMaker::RegisterMaker register_inherits_check(
+ InheritsCheck::identifier(), &MakeEbuildCheck<InheritsCheck>::make_ebuild_check);
+ }
+}
+
+#endif