aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAvatar Ciaran McCreesh <ciaran.mccreesh@googlemail.com> 2006-02-15 13:57:52 +0000
committerAvatar Ciaran McCreesh <ciaran.mccreesh@googlemail.com> 2006-02-15 13:57:52 +0000
commitdd285fe535fd4c3c63c5f28cde68e82791d32c93 (patch)
tree46d2c850bcd7ff17c4dbf51eb51032a32cdb011f
parente0422ec4438cdc63ee0aeb02414c66bc3147c17c (diff)
downloadpaludis-dd285fe535fd4c3c63c5f28cde68e82791d32c93.tar.gz
paludis-dd285fe535fd4c3c63c5f28cde68e82791d32c93.tar.xz
Check RDEPEND/PDEPEND overlap
-rw-r--r--paludis/qa/files.m41
-rw-r--r--paludis/qa/rdepend_pdepend_overlap_check.cc124
-rw-r--r--paludis/qa/rdepend_pdepend_overlap_check.hh51
3 files changed, 176 insertions, 0 deletions
diff --git a/paludis/qa/files.m4 b/paludis/qa/files.m4
index 16b54d7..d5b500c 100644
--- a/paludis/qa/files.m4
+++ b/paludis/qa/files.m4
@@ -33,6 +33,7 @@ add(`package_dir_check', `hh', `cc')
add(`package_name_check', `hh', `cc', `test', `testscript')
add(`parse_deps_check', `hh', `cc')
add(`rdepend_packages_check', `hh', `cc')
+add(`rdepend_pdepend_overlap_check', `hh', `cc')
add(`qa', `hh', `cc')
add(`slot_check', `hh', `cc')
diff --git a/paludis/qa/rdepend_pdepend_overlap_check.cc b/paludis/qa/rdepend_pdepend_overlap_check.cc
new file mode 100644
index 0000000..a31ae17
--- /dev/null
+++ b/paludis/qa/rdepend_pdepend_overlap_check.cc
@@ -0,0 +1,124 @@
+/* vim: set sw=4 sts=4 et foldmethod=syntax : */
+
+/*
+ * Copyright (c) 2006 Ciaran McCreesh <ciaranm@gentoo.org>
+ *
+ * This file is part of the Paludis package manager. Paludis is free software;
+ * you can redistribute it and/or modify it under the terms of the GNU General
+ * Public License version 2, as published by the Free Software Foundation.
+ *
+ * Paludis is distributed in the hope that it will be useful, but WITHOUT ANY
+ * WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+ * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
+ * details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc., 59 Temple
+ * Place, Suite 330, Boston, MA 02111-1307 USA
+ */
+
+#include "rdepend_pdepend_overlap_check.hh"
+#include <paludis/dep_parser.hh>
+#include <paludis/dep_atom_visitor.hh>
+#include <paludis/any_dep_atom.hh>
+#include <paludis/all_dep_atom.hh>
+#include <paludis/package_dep_atom.hh>
+#include <paludis/block_dep_atom.hh>
+#include <paludis/use_dep_atom.hh>
+#include <paludis/join.hh>
+
+using namespace paludis;
+using namespace paludis::qa;
+
+namespace
+{
+ struct Collector :
+ DepAtomVisitorTypes::ConstVisitor
+ {
+ std::set<QualifiedPackageName> result;
+
+ Collector()
+ {
+ }
+
+ void visit(const PackageDepAtom * const p)
+ {
+ result.insert(p->package());
+ }
+
+ void visit(const AllDepAtom * const a)
+ {
+ std::for_each(a->begin(), a->end(), accept_visitor(this));
+ }
+
+ void visit(const AnyDepAtom * const a)
+ {
+ std::for_each(a->begin(), a->end(), accept_visitor(this));
+ }
+
+ void visit(const UseDepAtom * const u)
+ {
+ std::for_each(u->begin(), u->end(), accept_visitor(this));
+ }
+
+ void visit(const BlockDepAtom * const)
+ {
+ }
+ };
+}
+
+RdependPdependOverlapCheck::RdependPdependOverlapCheck()
+{
+}
+
+CheckResult
+RdependPdependOverlapCheck::operator() (const EbuildCheckData & e) const
+{
+ CheckResult result(stringify(e.get<ecd_name>()) + "-" + stringify(e.get<ecd_version>()),
+ identifier());
+
+ try
+ {
+ PackageDatabaseEntry ee(e.get<ecd_name>(), e.get<ecd_version>(),
+ e.get<ecd_environment>()->package_database()->favourite_repository());
+ VersionMetadata::ConstPointer metadata(
+ e.get<ecd_environment>()->package_database()->fetch_metadata(ee));
+
+ Collector rdepend_collector;
+ std::string rdepend(metadata->get(vmk_rdepend));
+ DepParser::parse(rdepend)->accept(&rdepend_collector);
+
+ Collector pdepend_collector;
+ std::string pdepend(metadata->get(vmk_pdepend));
+ DepParser::parse(pdepend)->accept(&pdepend_collector);
+
+ std::set<QualifiedPackageName> overlap;
+ std::set_intersection(rdepend_collector.result.begin(), rdepend_collector.result.end(),
+ pdepend_collector.result.begin(), pdepend_collector.result.end(),
+ std::inserter(overlap, overlap.begin()));
+
+ if (! overlap.empty())
+ result << Message(qal_major, "Overlap between RDEPEND and PDEPEND: '" +
+ join(overlap.begin(), overlap.end(), "', ") + "'");
+ }
+ catch (const InternalError &)
+ {
+ throw;
+ }
+ catch (const Exception & e)
+ {
+ result << Message(qal_fatal, "Caught Exception '" + e.message() + "' ("
+ + e.what() + ")");
+ }
+
+ return result;
+}
+
+const std::string &
+RdependPdependOverlapCheck::identifier()
+{
+ static const std::string id("rdepend pdepend overlap");
+ return id;
+}
+
+
diff --git a/paludis/qa/rdepend_pdepend_overlap_check.hh b/paludis/qa/rdepend_pdepend_overlap_check.hh
new file mode 100644
index 0000000..547c712
--- /dev/null
+++ b/paludis/qa/rdepend_pdepend_overlap_check.hh
@@ -0,0 +1,51 @@
+/* vim: set sw=4 sts=4 et foldmethod=syntax : */
+
+/*
+ * Copyright (c) 2006 Ciaran McCreesh <ciaranm@gentoo.org>
+ *
+ * This file is part of the Paludis package manager. Paludis is free software;
+ * you can redistribute it and/or modify it under the terms of the GNU General
+ * Public License version 2, as published by the Free Software Foundation.
+ *
+ * Paludis is distributed in the hope that it will be useful, but WITHOUT ANY
+ * WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+ * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
+ * details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc., 59 Temple
+ * Place, Suite 330, Boston, MA 02111-1307 USA
+ */
+
+#ifndef PALUDIS_GUARD_PALUDIS_QA_RDEPEND_PDEPEND_OVERLAP_CHECK_HH
+#define PALUDIS_GUARD_PALUDIS_QA_RDEPEND_PDEPEND_OVERLAP_CHECK_HH 1
+
+#include <paludis/qa/ebuild_check.hh>
+#include <string>
+
+namespace paludis
+{
+ namespace qa
+ {
+ class RdependPdependOverlapCheck :
+ public EbuildCheck
+ {
+ public:
+ RdependPdependOverlapCheck();
+
+ CheckResult operator() (const EbuildCheckData &) const;
+
+ static const std::string & identifier();
+
+ virtual std::string describe() const
+ {
+ return "Checks for RDEPEND/PDEPEND overlap";
+ }
+ };
+
+ static const EbuildCheckMaker::RegisterMaker register_rdepend_pdepend_overlap_check(
+ RdependPdependOverlapCheck::identifier(), &make_ebuild_check<RdependPdependOverlapCheck>);
+ }
+}
+
+#endif