aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAvatar Saleem Abdulrasool <compnerd@compnerd.org> 2016-01-27 09:27:11 -0800
committerAvatar Saleem Abdulrasool <compnerd@compnerd.org> 2016-01-31 10:53:51 -0800
commitd868ec2ef75b934015089f03283efbf1ce8a1741 (patch)
tree248f2f6f1cf204efc06b423813546577548b2929
parent1463e3ebfb5b5450a79eb56e64ecdf0a07a3e958 (diff)
downloadpaludis-d868ec2ef75b934015089f03283efbf1ce8a1741.tar.gz
paludis-d868ec2ef75b934015089f03283efbf1ce8a1741.tar.xz
paludis: remove unnecessary "de-optimization"
If GCC removes this in this case, it will be forming invalid code and should be fixed. Remove the workaround to prevent a GCC mis-optimization. Identified by clang.
-rw-r--r--paludis/util/visitor.hh4
1 files changed, 1 insertions, 3 deletions
diff --git a/paludis/util/visitor.hh b/paludis/util/visitor.hh
index a49776e..4757c0b 100644
--- a/paludis/util/visitor.hh
+++ b/paludis/util/visitor.hh
@@ -271,9 +271,7 @@ namespace paludis
virtual void forward_visit(typename TypeList_::Item & n)
{
- /* avoid gcc being too clever about noreturn */
- if (this)
- static_cast<RealClass_ *>(this)->perform_visit(n);
+ static_cast<RealClass_ *>(this)->perform_visit(n);
}
};