aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAvatar Ciaran McCreesh <ciaran.mccreesh@googlemail.com> 2006-02-15 13:02:23 +0000
committerAvatar Ciaran McCreesh <ciaran.mccreesh@googlemail.com> 2006-02-15 13:02:23 +0000
commitb42d5db672cc5ce81b35ffa6d5f41207dc420ee0 (patch)
treec082eacdd0fbcfd9f04c92608f31920dc3163e9f
parent807fbf0fe56d8fb53855017f912efcff6518cb20 (diff)
downloadpaludis-b42d5db672cc5ce81b35ffa6d5f41207dc420ee0.tar.gz
paludis-b42d5db672cc5ce81b35ffa6d5f41207dc420ee0.tar.xz
Check || () block sanity
-rw-r--r--paludis/qa/dep_any_check.cc132
-rw-r--r--paludis/qa/dep_any_check.hh51
-rw-r--r--paludis/qa/files.m41
3 files changed, 184 insertions, 0 deletions
diff --git a/paludis/qa/dep_any_check.cc b/paludis/qa/dep_any_check.cc
new file mode 100644
index 0000000..dc8bb51
--- /dev/null
+++ b/paludis/qa/dep_any_check.cc
@@ -0,0 +1,132 @@
+/* vim: set sw=4 sts=4 et foldmethod=syntax : */
+
+/*
+ * Copyright (c) 2006 Ciaran McCreesh <ciaranm@gentoo.org>
+ *
+ * This file is part of the Paludis package manager. Paludis is free software;
+ * you can redistribute it and/or modify it under the terms of the GNU General
+ * Public License version 2, as published by the Free Software Foundation.
+ *
+ * Paludis is distributed in the hope that it will be useful, but WITHOUT ANY
+ * WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+ * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
+ * details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc., 59 Temple
+ * Place, Suite 330, Boston, MA 02111-1307 USA
+ */
+
+#include "dep_any_check.hh"
+
+#include <paludis/dep_parser.hh>
+#include <paludis/dep_atom_visitor.hh>
+#include <paludis/any_dep_atom.hh>
+#include <paludis/all_dep_atom.hh>
+#include <paludis/package_dep_atom.hh>
+#include <paludis/block_dep_atom.hh>
+#include <paludis/use_dep_atom.hh>
+#include <paludis/save.hh>
+
+using namespace paludis;
+using namespace paludis::qa;
+
+namespace
+{
+ struct Checker :
+ DepAtomVisitorTypes::ConstVisitor
+ {
+ CheckResult & result;
+ const std::string role;
+ bool in_any;
+
+ Checker(CheckResult & rr, const std::string & r) :
+ result(rr),
+ role(r),
+ in_any(false)
+ {
+ }
+
+ void visit(const PackageDepAtom * const)
+ {
+ }
+
+ void visit(const AllDepAtom * const a)
+ {
+ /* yes, the following line is correct. */
+ Save<bool> in_any_save(&in_any, false);
+ std::for_each(a->begin(), a->end(), accept_visitor(this));
+ }
+
+ void visit(const AnyDepAtom * const a)
+ {
+ Save<bool> in_any_save(&in_any, true);
+ if (a->begin() == a->end())
+ result << Message(qal_minor, "Empty || ( ) block in " + role);
+ else
+ std::for_each(a->begin(), a->end(), accept_visitor(this));
+ }
+
+ void visit(const UseDepAtom * const u)
+ {
+ if (in_any)
+ result << Message(qal_maybe, "Conditional on '" + stringify(u->flag()) +
+ "' inside || ( ) block in " + role);
+ std::for_each(u->begin(), u->end(), accept_visitor(this));
+ }
+
+ void visit(const BlockDepAtom * const)
+ {
+ }
+ };
+}
+
+DepAnyCheck::DepAnyCheck()
+{
+}
+
+CheckResult
+DepAnyCheck::operator() (const EbuildCheckData & e) const
+{
+ CheckResult result(stringify(e.get<ecd_name>()) + "-" + stringify(e.get<ecd_version>()),
+ identifier());
+
+ try
+ {
+ PackageDatabaseEntry ee(e.get<ecd_name>(), e.get<ecd_version>(),
+ e.get<ecd_environment>()->package_database()->favourite_repository());
+ VersionMetadata::ConstPointer metadata(
+ e.get<ecd_environment>()->package_database()->fetch_metadata(ee));
+
+ Checker depend_checker(result, "DEPEND");
+ std::string depend(metadata->get(vmk_depend));
+ DepParser::parse(depend)->accept(&depend_checker);
+
+ Checker rdepend_checker(result, "RDEPEND");
+ std::string rdepend(metadata->get(vmk_rdepend));
+ DepParser::parse(rdepend)->accept(&rdepend_checker);
+
+ Checker pdepend_checker(result, "PDEPEND");
+ std::string pdepend(metadata->get(vmk_pdepend));
+ DepParser::parse(pdepend)->accept(&pdepend_checker);
+ }
+ catch (const InternalError &)
+ {
+ throw;
+ }
+ catch (const Exception & e)
+ {
+ result << Message(qal_fatal, "Caught Exception '" + e.message() + "' ("
+ + e.what() + ")");
+ }
+
+ return result;
+}
+
+const std::string &
+DepAnyCheck::identifier()
+{
+ static const std::string id("any deps");
+ return id;
+}
+
diff --git a/paludis/qa/dep_any_check.hh b/paludis/qa/dep_any_check.hh
new file mode 100644
index 0000000..45d1b1c
--- /dev/null
+++ b/paludis/qa/dep_any_check.hh
@@ -0,0 +1,51 @@
+/* vim: set sw=4 sts=4 et foldmethod=syntax : */
+
+/*
+ * Copyright (c) 2006 Ciaran McCreesh <ciaranm@gentoo.org>
+ *
+ * This file is part of the Paludis package manager. Paludis is free software;
+ * you can redistribute it and/or modify it under the terms of the GNU General
+ * Public License version 2, as published by the Free Software Foundation.
+ *
+ * Paludis is distributed in the hope that it will be useful, but WITHOUT ANY
+ * WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+ * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
+ * details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc., 59 Temple
+ * Place, Suite 330, Boston, MA 02111-1307 USA
+ */
+
+#ifndef PALUDIS_GUARD_PALUDIS_QA_DEP_ANY_CHECK_HH
+#define PALUDIS_GUARD_PALUDIS_QA_DEP_ANY_CHECK_HH 1
+
+#include <paludis/qa/ebuild_check.hh>
+#include <string>
+
+namespace paludis
+{
+ namespace qa
+ {
+ class DepAnyCheck :
+ public EbuildCheck
+ {
+ public:
+ DepAnyCheck();
+
+ CheckResult operator() (const EbuildCheckData &) const;
+
+ static const std::string & identifier();
+
+ virtual std::string describe() const
+ {
+ return "Checks || ( ) block sanity in *DEPEND";
+ }
+ };
+
+ static const EbuildCheckMaker::RegisterMaker register_dep_any_check(
+ DepAnyCheck::identifier(), &make_ebuild_check<DepAnyCheck>);
+ }
+}
+
+#endif
diff --git a/paludis/qa/files.m4 b/paludis/qa/files.m4
index 916ba55..971d6c2 100644
--- a/paludis/qa/files.m4
+++ b/paludis/qa/files.m4
@@ -12,6 +12,7 @@ add(`changelog_check', `hh', `cc')
add(`check', `hh', `cc')
add(`check_result', `hh', `cc', `test')
add(`create_metadata_check', `hh', `cc')
+add(`dep_any_check', `hh', `cc')
add(`dep_flags_check', `hh', `cc')
add(`deps_exist_check', `hh', `cc')
add(`deps_visible_check', `hh', `cc')