aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAvatar Ciaran McCreesh <ciaran.mccreesh@googlemail.com> 2006-10-04 13:13:30 +0000
committerAvatar Ciaran McCreesh <ciaran.mccreesh@googlemail.com> 2006-10-04 13:13:30 +0000
commit9af8701376dc42d52d2bf18e526efe11286f7e43 (patch)
tree63a20b725b1cb4fe268d921fba4ef735e5f55314
parent7c67fb07d4666f2d7f80d6584edd445a5d595c95 (diff)
downloadpaludis-9af8701376dc42d52d2bf18e526efe11286f7e43.tar.gz
paludis-9af8701376dc42d52d2bf18e526efe11286f7e43.tar.xz
Add a deprecated functions qa check
-rw-r--r--paludis/qa/deprecated_functions_check.cc82
-rw-r--r--paludis/qa/deprecated_functions_check.hh51
-rw-r--r--paludis/qa/files.m41
3 files changed, 134 insertions, 0 deletions
diff --git a/paludis/qa/deprecated_functions_check.cc b/paludis/qa/deprecated_functions_check.cc
new file mode 100644
index 0000000..3556820
--- /dev/null
+++ b/paludis/qa/deprecated_functions_check.cc
@@ -0,0 +1,82 @@
+/* vim: set sw=4 sts=4 et foldmethod=syntax : */
+
+/*
+ * Copyright (c) 2006 Ciaran McCreesh <ciaranm@ciaranm.org>
+ *
+ * This file is part of the Paludis package manager. Paludis is free software;
+ * you can redistribute it and/or modify it under the terms of the GNU General
+ * Public License version 2, as published by the Free Software Foundation.
+ *
+ * Paludis is distributed in the hope that it will be useful, but WITHOUT ANY
+ * WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+ * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
+ * details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc., 59 Temple
+ * Place, Suite 330, Boston, MA 02111-1307 USA
+ */
+
+#include <fstream>
+#include <paludis/qa/deprecated_functions_check.hh>
+#include <paludis/util/is_file_with_extension.hh>
+#include <pcre++.h>
+
+using namespace paludis;
+using namespace paludis::qa;
+
+DeprecatedFunctionsCheck::DeprecatedFunctionsCheck()
+{
+}
+
+CheckResult
+DeprecatedFunctionsCheck::operator() (const FSEntry & f) const
+{
+ CheckResult result(f, identifier());
+
+ static pcrepp::Pcre::Pcre r_comment("^\\s*#");
+ static pcrepp::Pcre::Pcre r_check_kv("\\bcheck_KV\\b");
+
+ if (! f.is_regular_file())
+ result << Message(qal_skip, "Not a regular file");
+ else if (! IsFileWithExtension(".ebuild")(f) &&
+ ! IsFileWithExtension(".eclass")(f))
+ result << Message(qal_skip, "Not an ebuild or eclass file");
+ else
+ {
+ std::ifstream ff(stringify(f).c_str());
+ if (! ff)
+ result << Message(qal_major, "Can't read file");
+ else
+ {
+ std::string s;
+ unsigned line_number(0);
+ while (std::getline(ff, s))
+ {
+ ++line_number;
+
+ if (s.empty() || r_comment.search(s))
+ continue;
+
+ if (r_check_kv.search(s))
+ {
+ result << Message(qal_major, "Deprecated call to check_KV on line "
+ + stringify(line_number));
+ continue;
+ }
+ }
+ }
+ }
+
+ return result;
+}
+
+const std::string &
+DeprecatedFunctionsCheck::identifier()
+{
+ static const std::string id("deprecated_functions");
+ return id;
+}
+
+
+
diff --git a/paludis/qa/deprecated_functions_check.hh b/paludis/qa/deprecated_functions_check.hh
new file mode 100644
index 0000000..042faa9
--- /dev/null
+++ b/paludis/qa/deprecated_functions_check.hh
@@ -0,0 +1,51 @@
+/* vim: set sw=4 sts=4 et foldmethod=syntax : */
+
+/*
+ * Copyright (c) 2006 Ciaran McCreesh <ciaranm@ciaranm.org>
+ *
+ * This file is part of the Paludis package manager. Paludis is free software;
+ * you can redistribute it and/or modify it under the terms of the GNU General
+ * Public License version 2, as published by the Free Software Foundation.
+ *
+ * Paludis is distributed in the hope that it will be useful, but WITHOUT ANY
+ * WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+ * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
+ * details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc., 59 Temple
+ * Place, Suite 330, Boston, MA 02111-1307 USA
+ */
+
+#ifndef PALUDIS_GUARD_PALUDIS_QA_DEPRECATED_FUNCTIONS_CHECK_HH
+#define PALUDIS_GUARD_PALUDIS_QA_DEPRECATED_FUNCTIONS_CHECK_HH 1
+
+#include <paludis/qa/file_check.hh>
+#include <string>
+
+namespace paludis
+{
+ namespace qa
+ {
+ class DeprecatedFunctionsCheck :
+ public FileCheck
+ {
+ public:
+ DeprecatedFunctionsCheck();
+
+ CheckResult operator() (const FSEntry &) const;
+
+ static const std::string & identifier();
+
+ virtual std::string describe() const
+ {
+ return "Checks for deprecated functions";
+ }
+ };
+
+ static const FileCheckMaker::RegisterMaker register_deprecated_functions_check(
+ DeprecatedFunctionsCheck::identifier(), &MakeFileCheck<DeprecatedFunctionsCheck>::make_file_check);
+ }
+}
+
+#endif
diff --git a/paludis/qa/files.m4 b/paludis/qa/files.m4
index ddd609d..2af2e7c 100644
--- a/paludis/qa/files.m4
+++ b/paludis/qa/files.m4
@@ -16,6 +16,7 @@ add(`defaults_check', `hh', `cc', `test', `testscript')
add(`dep_any_check', `hh', `cc')
add(`dep_flags_check', `hh', `cc')
add(`dep_packages_check', `hh', `cc')
+add(`deprecated_functions_check', `hh', `cc')
add(`deps_exist_check', `hh', `cc')
add(`deps_visible_check', `hh', `cc')
add(`description_check', `hh', `cc')