aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAvatar Ciaran McCreesh <ciaran.mccreesh@googlemail.com> 2006-02-15 13:18:59 +0000
committerAvatar Ciaran McCreesh <ciaran.mccreesh@googlemail.com> 2006-02-15 13:18:59 +0000
commit0643f37d4079e31b0d1d6b4cd66dd334e01e8d28 (patch)
treebeaf664fd88261891fef295f462a54b8970146a4
parentb42d5db672cc5ce81b35ffa6d5f41207dc420ee0 (diff)
downloadpaludis-0643f37d4079e31b0d1d6b4cd66dd334e01e8d28.tar.gz
paludis-0643f37d4079e31b0d1d6b4cd66dd334e01e8d28.tar.xz
Check for suspicious RDEPEND entries
-rw-r--r--paludis/qa/files.m41
-rw-r--r--paludis/qa/rdepend_packages_check.cc128
-rw-r--r--paludis/qa/rdepend_packages_check.hh51
3 files changed, 180 insertions, 0 deletions
diff --git a/paludis/qa/files.m4 b/paludis/qa/files.m4
index 971d6c2..16b54d7 100644
--- a/paludis/qa/files.m4
+++ b/paludis/qa/files.m4
@@ -32,6 +32,7 @@ add(`metadata_check', `hh', `cc')
add(`package_dir_check', `hh', `cc')
add(`package_name_check', `hh', `cc', `test', `testscript')
add(`parse_deps_check', `hh', `cc')
+add(`rdepend_packages_check', `hh', `cc')
add(`qa', `hh', `cc')
add(`slot_check', `hh', `cc')
diff --git a/paludis/qa/rdepend_packages_check.cc b/paludis/qa/rdepend_packages_check.cc
new file mode 100644
index 0000000..c922574
--- /dev/null
+++ b/paludis/qa/rdepend_packages_check.cc
@@ -0,0 +1,128 @@
+/* vim: set sw=4 sts=4 et foldmethod=syntax : */
+
+/*
+ * Copyright (c) 2006 Ciaran McCreesh <ciaranm@gentoo.org>
+ *
+ * This file is part of the Paludis package manager. Paludis is free software;
+ * you can redistribute it and/or modify it under the terms of the GNU General
+ * Public License version 2, as published by the Free Software Foundation.
+ *
+ * Paludis is distributed in the hope that it will be useful, but WITHOUT ANY
+ * WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+ * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
+ * details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc., 59 Temple
+ * Place, Suite 330, Boston, MA 02111-1307 USA
+ */
+
+#include "rdepend_packages_check.hh"
+#include <paludis/dep_parser.hh>
+#include <paludis/dep_atom_visitor.hh>
+#include <paludis/any_dep_atom.hh>
+#include <paludis/all_dep_atom.hh>
+#include <paludis/package_dep_atom.hh>
+#include <paludis/block_dep_atom.hh>
+#include <paludis/use_dep_atom.hh>
+
+using namespace paludis;
+using namespace paludis::qa;
+
+namespace
+{
+ struct Checker :
+ DepAtomVisitorTypes::ConstVisitor
+ {
+ CheckResult & result;
+ const std::string role;
+ const std::set<QualifiedPackageName> & suspicious;
+
+ Checker(CheckResult & rr, const std::string & r, const std::set<QualifiedPackageName> & s) :
+ result(rr),
+ role(r),
+ suspicious(s)
+ {
+ }
+
+ void visit(const PackageDepAtom * const p)
+ {
+ if (suspicious.end() != suspicious.find(p->package()))
+ result << Message(qal_maybe, "Suspicious " + role + " entry '"
+ + stringify(p->package()) + "'");
+ }
+
+ void visit(const AllDepAtom * const a)
+ {
+ std::for_each(a->begin(), a->end(), accept_visitor(this));
+ }
+
+ void visit(const AnyDepAtom * const a)
+ {
+ std::for_each(a->begin(), a->end(), accept_visitor(this));
+ }
+
+ void visit(const UseDepAtom * const u)
+ {
+ std::for_each(u->begin(), u->end(), accept_visitor(this));
+ }
+
+ void visit(const BlockDepAtom * const)
+ {
+ }
+ };
+}
+
+RdependPackagesCheck::RdependPackagesCheck()
+{
+}
+
+CheckResult
+RdependPackagesCheck::operator() (const EbuildCheckData & e) const
+{
+ CheckResult result(stringify(e.get<ecd_name>()) + "-" + stringify(e.get<ecd_version>()),
+ identifier());
+
+ try
+ {
+ PackageDatabaseEntry ee(e.get<ecd_name>(), e.get<ecd_version>(),
+ e.get<ecd_environment>()->package_database()->favourite_repository());
+ VersionMetadata::ConstPointer metadata(
+ e.get<ecd_environment>()->package_database()->fetch_metadata(ee));
+
+ static std::set<QualifiedPackageName> suspicious;
+ if (suspicious.empty())
+ {
+ suspicious.insert(QualifiedPackageName("dev-util/pkgconfig"));
+ suspicious.insert(QualifiedPackageName("sys-devel/autoconf"));
+ suspicious.insert(QualifiedPackageName("sys-devel/automake"));
+ suspicious.insert(QualifiedPackageName("sys-devel/flex"));
+ suspicious.insert(QualifiedPackageName("sys-devel/gettext"));
+ suspicious.insert(QualifiedPackageName("sys-devel/libtool"));
+ suspicious.insert(QualifiedPackageName("sys-devel/patch"));
+ }
+
+ Checker rdepend_checker(result, "RDEPEND", suspicious);
+ std::string rdepend(metadata->get(vmk_rdepend));
+ DepParser::parse(rdepend)->accept(&rdepend_checker);
+ }
+ catch (const InternalError &)
+ {
+ throw;
+ }
+ catch (const Exception & e)
+ {
+ result << Message(qal_fatal, "Caught Exception '" + e.message() + "' ("
+ + e.what() + ")");
+ }
+
+ return result;
+}
+
+const std::string &
+RdependPackagesCheck::identifier()
+{
+ static const std::string id("rdepend packages");
+ return id;
+}
+
diff --git a/paludis/qa/rdepend_packages_check.hh b/paludis/qa/rdepend_packages_check.hh
new file mode 100644
index 0000000..05b7ab7
--- /dev/null
+++ b/paludis/qa/rdepend_packages_check.hh
@@ -0,0 +1,51 @@
+/* vim: set sw=4 sts=4 et foldmethod=syntax : */
+
+/*
+ * Copyright (c) 2006 Ciaran McCreesh <ciaranm@gentoo.org>
+ *
+ * This file is part of the Paludis package manager. Paludis is free software;
+ * you can redistribute it and/or modify it under the terms of the GNU General
+ * Public License version 2, as published by the Free Software Foundation.
+ *
+ * Paludis is distributed in the hope that it will be useful, but WITHOUT ANY
+ * WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+ * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
+ * details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc., 59 Temple
+ * Place, Suite 330, Boston, MA 02111-1307 USA
+ */
+
+#ifndef PALUDIS_GUARD_PALUDIS_QA_RDEPEND_PACKAGES_CHECK_HH
+#define PALUDIS_GUARD_PALUDIS_QA_RDEPEND_PACKAGES_CHECK_HH 1
+
+#include <paludis/qa/ebuild_check.hh>
+#include <string>
+
+namespace paludis
+{
+ namespace qa
+ {
+ class RdependPackagesCheck :
+ public EbuildCheck
+ {
+ public:
+ RdependPackagesCheck();
+
+ CheckResult operator() (const EbuildCheckData &) const;
+
+ static const std::string & identifier();
+
+ virtual std::string describe() const
+ {
+ return "Checks packages that usually should not be in RDEPEND";
+ }
+ };
+
+ static const EbuildCheckMaker::RegisterMaker register_rdepend_packages_check(
+ RdependPackagesCheck::identifier(), &make_ebuild_check<RdependPackagesCheck>);
+ }
+}
+
+#endif