Don't need can_be_favourite_repository

14 files changed, 0 insertions, 61 deletions

diff --git a/paludis/repositories/gemcutter/gemcutter_repository.cc b/paludis/repositories/gemcutter/gemcutter_repository.cc
index b03a21b9f..1cdeecb51 100644
--- a/paludis/repositories/gemcutter/gemcutter_repository.cc
+++ b/paludis/repositories/gemcutter/gemcutter_repository.cc
@@ -100,12 +100,6 @@ GemcutterRepository::~GemcutterRepository()
 {
 }
 
-bool
-GemcutterRepository::can_be_favourite_repository() const
-{
-    return false;
-}
-
 const bool
 GemcutterRepository::is_unimportant() const
 {
diff --git a/paludis/repositories/gemcutter/gemcutter_repository.hh b/paludis/repositories/gemcutter/gemcutter_repository.hh
index 428d0a63d..e17a660f2 100644
--- a/paludis/repositories/gemcutter/gemcutter_repository.hh
+++ b/paludis/repositories/gemcutter/gemcutter_repository.hh
@@ -67,8 +67,6 @@ namespace paludis
                 GemcutterRepository(const GemcutterRepositoryParams &);
                 ~GemcutterRepository();
 
-                virtual bool can_be_favourite_repository() const;
-
                 virtual const bool is_unimportant() const;
 
                 virtual const std::shared_ptr<const MetadataValueKey<std::string> > format_key() const;
diff --git a/paludis/repositories/repository/repository_repository.cc b/paludis/repositories/repository/repository_repository.cc
index 0da3736a9..dd842bbda 100644
--- a/paludis/repositories/repository/repository_repository.cc
+++ b/paludis/repositories/repository/repository_repository.cc
@@ -110,12 +110,6 @@ RepositoryRepository::~RepositoryRepository()
 {
 }
 
-bool
-RepositoryRepository::can_be_favourite_repository() const
-{
-    return false;
-}
-
 const bool
 RepositoryRepository::is_unimportant() const
 {
diff --git a/paludis/repositories/repository/repository_repository.hh b/paludis/repositories/repository/repository_repository.hh
index 604607875..f2bb0316e 100644
--- a/paludis/repositories/repository/repository_repository.hh
+++ b/paludis/repositories/repository/repository_repository.hh
@@ -71,8 +71,6 @@ namespace paludis
                 RepositoryRepository(const RepositoryRepositoryParams &);
                 ~RepositoryRepository();
 
-                virtual bool can_be_favourite_repository() const;
-
                 virtual const bool is_unimportant() const;
 
                 virtual const std::shared_ptr<const MetadataValueKey<std::string> > format_key() const;
diff --git a/paludis/repositories/unavailable/unavailable_repository.cc b/paludis/repositories/unavailable/unavailable_repository.cc
index 4739c7202..a5e554bda 100644
--- a/paludis/repositories/unavailable/unavailable_repository.cc
+++ b/paludis/repositories/unavailable/unavailable_repository.cc
@@ -118,12 +118,6 @@ UnavailableRepository::~UnavailableRepository()
 {
 }
 
-bool
-UnavailableRepository::can_be_favourite_repository() const
-{
-    return false;
-}
-
 const bool
 UnavailableRepository::is_unimportant() const
 {
diff --git a/paludis/repositories/unavailable/unavailable_repository.hh b/paludis/repositories/unavailable/unavailable_repository.hh
index 3d5fdd569..e2ef3de61 100644
--- a/paludis/repositories/unavailable/unavailable_repository.hh
+++ b/paludis/repositories/unavailable/unavailable_repository.hh
@@ -70,8 +70,6 @@ namespace paludis
                 UnavailableRepository(const UnavailableRepositoryParams &);
                 ~UnavailableRepository();
 
-                virtual bool can_be_favourite_repository() const;
-
                 virtual const bool is_unimportant() const;
 
                 virtual const std::shared_ptr<const MetadataValueKey<std::string> > format_key() const;
diff --git a/paludis/repositories/unwritten/unwritten_repository.cc b/paludis/repositories/unwritten/unwritten_repository.cc
index c23cd8442..7aa9bc409 100644
--- a/paludis/repositories/unwritten/unwritten_repository.cc
+++ b/paludis/repositories/unwritten/unwritten_repository.cc
@@ -118,12 +118,6 @@ UnwrittenRepository::is_unimportant() const
     return true;
 }
 
-bool
-UnwrittenRepository::can_be_favourite_repository() const
-{
-    return false;
-}
-
 void
 UnwrittenRepository::_add_metadata_keys()
 {
diff --git a/paludis/repositories/unwritten/unwritten_repository.hh b/paludis/repositories/unwritten/unwritten_repository.hh
index 5c293954a..729f24c9e 100644
--- a/paludis/repositories/unwritten/unwritten_repository.hh
+++ b/paludis/repositories/unwritten/unwritten_repository.hh
@@ -71,8 +71,6 @@ namespace paludis
 
                 virtual const bool is_unimportant() const;
 
-                virtual bool can_be_favourite_repository() const;
-
                 virtual const std::shared_ptr<const MetadataValueKey<std::string> > format_key() const;
                 virtual const std::shared_ptr<const MetadataValueKey<FSPath> > location_key() const;
                 virtual const std::shared_ptr<const MetadataValueKey<FSPath> > installed_root_key() const;
diff --git a/paludis/repositories/virtuals/installed_virtuals_repository.cc b/paludis/repositories/virtuals/installed_virtuals_repository.cc
index ff4ec82ae..7d017a428 100644
--- a/paludis/repositories/virtuals/installed_virtuals_repository.cc
+++ b/paludis/repositories/virtuals/installed_virtuals_repository.cc
@@ -232,12 +232,6 @@ InstalledVirtualsRepository::perform_hook(const Hook & hook, const std::shared_p
     return make_named_values<HookResult>(n::max_exit_status() = 0, n::output() = "");
 }
 
-bool
-InstalledVirtualsRepository::can_be_favourite_repository() const
-{
-    return false;
-}
-
 const bool
 InstalledVirtualsRepository::is_unimportant() const
 {
diff --git a/paludis/repositories/virtuals/installed_virtuals_repository.hh b/paludis/repositories/virtuals/installed_virtuals_repository.hh
index c78d81363..6dc9e239e 100644
--- a/paludis/repositories/virtuals/installed_virtuals_repository.hh
+++ b/paludis/repositories/virtuals/installed_virtuals_repository.hh
@@ -78,8 +78,6 @@ namespace paludis
 
             virtual void invalidate();
 
-            virtual bool can_be_favourite_repository() const;
-
             virtual const bool is_unimportant() const;
 
             HookResult perform_hook(const Hook &, const std::shared_ptr<OutputManager> &)
diff --git a/paludis/repositories/virtuals/virtuals_repository.cc b/paludis/repositories/virtuals/virtuals_repository.cc
index ca1e9aa41..bb6026d91 100644
--- a/paludis/repositories/virtuals/virtuals_repository.cc
+++ b/paludis/repositories/virtuals/virtuals_repository.cc
@@ -327,12 +327,6 @@ VirtualsRepository::make_virtual_package_id(
     return std::make_shared<virtuals::VirtualsPackageID>(_imp->env, name(), virtual_name, provider, true);
 }
 
-bool
-VirtualsRepository::can_be_favourite_repository() const
-{
-    return false;
-}
-
 const bool
 VirtualsRepository::is_unimportant() const
 {
diff --git a/paludis/repositories/virtuals/virtuals_repository.hh b/paludis/repositories/virtuals/virtuals_repository.hh
index 430cd829e..3544ecce1 100644
--- a/paludis/repositories/virtuals/virtuals_repository.hh
+++ b/paludis/repositories/virtuals/virtuals_repository.hh
@@ -78,8 +78,6 @@ namespace paludis
 
             virtual void invalidate();
 
-            virtual bool can_be_favourite_repository() const;
-
             virtual const bool is_unimportant() const;
 
             /* Repository */
diff --git a/paludis/repository.cc b/paludis/repository.cc
index 0805592f2..567c2ecd6 100644
--- a/paludis/repository.cc
+++ b/paludis/repository.cc
@@ -205,12 +205,6 @@ RepositoryManifestInterface::~RepositoryManifestInterface()
 {
 }
 
-bool
-Repository::can_be_favourite_repository() const
-{
-    return some_ids_might_support_action(SupportsActionTest<InstallAction>());
-}
-
 std::shared_ptr<const CategoryNamePartSet>
 Repository::unimportant_category_names(const RepositoryContentMayExcludes &) const
 {
diff --git a/paludis/repository.hh b/paludis/repository.hh
index 1d6b64d2a..a0cbe9370 100644
--- a/paludis/repository.hh
+++ b/paludis/repository.hh
@@ -288,13 +288,6 @@ namespace paludis
             const RepositoryName name() const PALUDIS_ATTRIBUTE((nothrow))
                 PALUDIS_ATTRIBUTE((warn_unused_result));
 
-            /**
-             * Are we allowed to be favourite repository?
-             *
-             * Clients may show packages from the favourite repository without the ::repository suffix.
-             */
-            virtual bool can_be_favourite_repository() const;
-
             ///\}
 
             ///\name Specific metadata keys